Bump some dependencies to mostly remove atty
#403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's no longer in our release dependency closure, but still in the test closure through two sources: * fuser uses clap v3 in its examples, which still depends on atty * fuser uses env-logger v0.9 in its examples, which still depends on atty Signed-off-by: James Bornholt <bornholt@amazon.com>
jamesbornholt
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
jamesbornholt
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
jamesbornholt
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
jamesbornholt
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
dannycjones
requested changes
Jul 24, 2023
There was a problem hiding this comment.
Compiles but Clap upgrade has a breaking change for arguments.
This example breaks, we just need to remove the -- from arg definitions on the list example.
❯ cargo run --example list -- --bucket doc-example-bucket
Finished dev [unoptimized + debuginfo] target(s) in 0.80s
Running `/Users/djonesoa/devel/mountpoint-s3/target/debug/examples/list --bucket doc-example-bucket`
thread 'main' panicked at 'Argument delimiter: long "--delimiter" must not start with a `-`, that will be handled by the parser', /Users/djonesoa/.cargo/registry/src/index.crates.io-6f17d22bba15001f/clap_builder-4.3.9/src/builder/debug_asserts.rs:79:13
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Signed-off-by: James Bornholt <bornholt@amazon.com>
jamesbornholt
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
jamesbornholt
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
jamesbornholt
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
jamesbornholt
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
|
I tested the other two but not that one :( |
dannycjones
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
It's no longer in our release dependency closure, but still in the test
closure through two sources:
atty
Does this change impact existing behavior?
No.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).