Abort upload on out-of-order writes #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
passaro
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
passaro
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
passaro
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
passaro
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
passaro
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
Signed-off-by: Alessandro Passaro <alexpax@amazon.co.uk>
Signed-off-by: Alessandro Passaro <alexpax@amazon.co.uk>
passaro
force-pushed
the
out-of-order-write-test
branch
from
5281dc0
to
779b1fc
Compare
passaro
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
passaro
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
passaro
changed the title
monthonk
reviewed
Jun 30, 2023
Comment on lines
+367
to
+372
| // The kernel doesn't guarantee to flush the data as soon as the file is closed. Currently, | ||
| // the file won't be visible on the file system until it's flushed to S3, and so trying to stat | ||
| // the file will fail. | ||
| // TODO we can remove this when we implement fsync, or change it when we make files visible | ||
| // during writes | ||
| std::thread::sleep(Duration::from_secs(5)); |
There was a problem hiding this comment.
I think we can now use fsync?
There was a problem hiding this comment.
Not really. A successful fsync guarantees that the file has been uploaded, but not currently that the inode has been updated.
jamesbornholt
approved these changes
Jun 30, 2023
sauraank
pushed a commit
to sauraank/mountpoint-s3
that referenced
this pull request
Jul 3, 2023
* Add fuse test for out-of-order writes Signed-off-by: Alessandro Passaro <alexpax@amazon.co.uk> * Abort upload after an out-of-order write attempt. Signed-off-by: Alessandro Passaro <alexpax@amazon.co.uk> --------- Signed-off-by: Alessandro Passaro <alexpax@amazon.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Out-of-order writes previously failed but would not abort the upload and would even allow to resume writing sequentially.
This change aborts the upload and mark the file handle has failed, so that subsequent operations (e.g. write, fsync) will return an error.
Does this change impact existing behavior?
Yes, the behavior of write when trying to write out-of-order has changed.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).