Reduce memory usage for strings in inode metadata #1346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alessandro Passaro <alexpax@amazon.co.uk>
Signed-off-by: Alessandro Passaro <alexpax@amazon.co.uk>
Signed-off-by: Alessandro Passaro <alexpax@amazon.co.uk>
passaro
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
Signed-off-by: Alessandro Passaro <alexpax@amazon.co.uk>
passaro
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
vladem
reviewed
Apr 3, 2025
| @@ -344,9 +344,9 @@ impl InodeStat { | |||
| /// restored, and so we override their permissions to 000 and reject reads to them. We also warn | |||
| /// the first time we see an object like this, because FUSE enforces the 000 permissions on our | |||
| /// behalf so we might not see an attempted `open` call. | |||
| fn is_readable(storage_class: Option<String>, restore_status: Option<RestoreStatus>) -> bool { | |||
| fn is_readable(storage_class: Option<&str>, restore_status: Option<RestoreStatus>) -> bool { | |||
There was a problem hiding this comment.
storage_class is still stored as String right? (don't see it changed to Box<str>)
There was a problem hiding this comment.
We do not store it in the inodes, it's only used here to determine the is_readable flag.
| // Allocate the new string with the correct capacity. | ||
| let mut key = | ||
| String::with_capacity(name_offset + name.len() + if kind == InodeKind::Directory { 1 } else { 0 }); | ||
| key.push_str(&self.key); | ||
| key.push_str(&name); |
There was a problem hiding this comment.
ensures that no slack capacity is wasted
regarding this aspect from the description, do you think slack capacity was added here, when pushing to the string? my assumption would be that initial allocation self.as_ref().to_owned() would use exactly the right amount of memory, so for etag and storage_class the saving is exactly one usize (previously used to track capacity)
There was a problem hiding this comment.
Yes, the slack capacity savings are only for keys. For etag and the children names we only save the usize field.
vladem
approved these changes
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce memory usage for strings included in inode metadata, like object keys, etags, and inode names. Using a
Box<str>instead of aStringensures that no slack capacity is wasted and saves theusizefield to keep track of the buffer capacity.Does this change impact existing behavior?
No functional changes.
Does this change need a changelog entry? Does it require a version change?
Yes.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).