Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for CRC64-NVME checksum algorithm #1235

Merged
merged 5 commits into from
Jan 27, 2025
Merged

Add support for CRC64-NVME checksum algorithm #1235

merged 5 commits into from
Jan 27, 2025

Conversation

passaro
Copy link
Contributor

@passaro passaro commented Jan 17, 2025

This change adds support for the CRC64-NVME checksum algorithm when using relevant operations in mountpoint-s3-client and when appending to existing objects through Mountpoint (using --incremental-upload mode).

Does this change impact existing behavior?

No.

Does this change need a changelog entry? Does it require a version change?

Yes.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).

@passaro passaro requested a deployment to PR integration tests January 17, 2025 10:16 — with GitHub Actions Waiting
@passaro passaro requested a deployment to PR integration tests January 17, 2025 10:16 — with GitHub Actions Waiting
@passaro passaro requested a deployment to PR integration tests January 17, 2025 10:16 — with GitHub Actions Waiting
@passaro passaro requested a deployment to PR integration tests January 17, 2025 10:16 — with GitHub Actions Waiting
@passaro passaro requested a deployment to PR integration tests January 17, 2025 10:16 — with GitHub Actions Waiting
@passaro passaro requested a deployment to PR integration tests January 17, 2025 10:16 — with GitHub Actions Waiting
@passaro passaro requested a deployment to PR integration tests January 17, 2025 10:16 — with GitHub Actions Waiting
@passaro passaro temporarily deployed to PR integration tests January 17, 2025 10:18 — with GitHub Actions Inactive
@passaro passaro temporarily deployed to PR integration tests January 17, 2025 10:18 — with GitHub Actions Inactive
@passaro passaro had a problem deploying to PR integration tests January 17, 2025 10:18 — with GitHub Actions Failure
@passaro passaro temporarily deployed to PR integration tests January 17, 2025 10:18 — with GitHub Actions Inactive
@passaro passaro had a problem deploying to PR integration tests January 17, 2025 10:18 — with GitHub Actions Failure
@passaro passaro temporarily deployed to PR integration tests January 17, 2025 10:18 — with GitHub Actions Inactive
@passaro passaro had a problem deploying to PR integration tests January 17, 2025 10:18 — with GitHub Actions Failure
@passaro passaro temporarily deployed to PR integration tests January 17, 2025 11:31 — with GitHub Actions Inactive
@passaro passaro had a problem deploying to PR integration tests January 17, 2025 11:31 — with GitHub Actions Failure
@passaro passaro had a problem deploying to PR integration tests January 17, 2025 11:31 — with GitHub Actions Failure
@passaro passaro had a problem deploying to PR integration tests January 17, 2025 11:31 — with GitHub Actions Failure
@passaro passaro temporarily deployed to PR integration tests January 17, 2025 11:31 — with GitHub Actions Inactive
@passaro passaro temporarily deployed to PR integration tests January 17, 2025 11:31 — with GitHub Actions Inactive
@passaro passaro temporarily deployed to PR integration tests January 17, 2025 11:31 — with GitHub Actions Inactive
@passaro passaro temporarily deployed to PR integration tests January 17, 2025 14:22 — with GitHub Actions Inactive
@passaro passaro temporarily deployed to PR integration tests January 17, 2025 14:22 — with GitHub Actions Inactive
@passaro passaro temporarily deployed to PR integration tests January 17, 2025 14:22 — with GitHub Actions Inactive
@passaro passaro had a problem deploying to PR integration tests January 17, 2025 14:22 — with GitHub Actions Failure
@passaro passaro temporarily deployed to PR integration tests January 17, 2025 14:22 — with GitHub Actions Inactive
@passaro passaro had a problem deploying to PR integration tests January 17, 2025 14:22 — with GitHub Actions Failure
@passaro passaro enabled auto-merge January 24, 2025 11:51
@passaro passaro requested a review from dannycjones January 24, 2025 14:23
dannycjones
dannycjones reviewed Jan 24, 2025
View reviewed changes
Copy link
Contributor

@dannycjones dannycjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed in-person, we want to extend test coverage as well for GetObject, HeadObject, GetObjectAttributes, ListObjectsV2. There will bit a little bit of missing impl on some of these.

@passaro passaro temporarily deployed to PR integration tests January 24, 2025 18:49 — with GitHub Actions Inactive
@passaro passaro had a problem deploying to PR integration tests January 24, 2025 18:49 — with GitHub Actions Failure
@passaro passaro had a problem deploying to PR integration tests January 24, 2025 18:49 — with GitHub Actions Failure
@passaro passaro had a problem deploying to PR integration tests January 24, 2025 18:49 — with GitHub Actions Failure
@passaro passaro had a problem deploying to PR integration tests January 24, 2025 18:50 — with GitHub Actions Failure
@passaro passaro had a problem deploying to PR integration tests January 24, 2025 18:50 — with GitHub Actions Failure
@passaro passaro had a problem deploying to PR integration tests January 24, 2025 18:50 — with GitHub Actions Failure
@passaro passaro requested a review from dannycjones January 24, 2025 18:51
passaro and others added 5 commits January 24, 2025 18:55
@passaro
Upgrade test dependency to aws-sdk-s3 1.69
c029749 
Signed-off-by: Alessandro Passaro <alexpax@amazon.co.uk>
@passaro
Add support for CRC64NVME
1d80ae1 
Signed-off-by: Alessandro Passaro <alexpax@amazon.co.uk>
@passaro
Add append test with crc64nvme
91c0440 
Signed-off-by: Alessandro Passaro <alexpax@amazon.co.uk>
@passaro
Add CHANGELOG entries
d098530 
Signed-off-by: Alessandro Passaro <alexpax@amazon.co.uk>
@dannycjones @passaro
Add missing tests and any impl for CRC64Nvme in ListObjectsV2, HeadOb…
d8bb32d 
…ject, GetObjectAttributes, GetObject

Signed-off-by: Daniel Carl Jones <djonesoa@amazon.com>
@passaro passaro temporarily deployed to PR integration tests January 24, 2025 18:56 — with GitHub Actions Inactive
@passaro passaro temporarily deployed to PR integration tests January 24, 2025 18:56 — with GitHub Actions Inactive
@passaro passaro temporarily deployed to PR integration tests January 24, 2025 18:56 — with GitHub Actions Inactive
@passaro passaro temporarily deployed to PR integration tests January 24, 2025 18:56 — with GitHub Actions Inactive
@passaro passaro temporarily deployed to PR integration tests January 24, 2025 18:56 — with GitHub Actions Inactive
@passaro passaro had a problem deploying to PR integration tests January 24, 2025 18:56 — with GitHub Actions Failure
@passaro passaro temporarily deployed to PR integration tests January 24, 2025 18:56 — with GitHub Actions Inactive
@passaro passaro temporarily deployed to PR integration tests January 25, 2025 10:28 — with GitHub Actions Inactive
dannycjones
dannycjones approved these changes Jan 27, 2025
View reviewed changes
Copy link
Contributor

@dannycjones dannycjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@passaro passaro added this pull request to the merge queue Jan 27, 2025
Merged via the queue into awslabs:main with commit 2089a3b Jan 27, 2025
24 checks passed
@passaro passaro deleted the crc64 branch January 27, 2025 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dannycjones dannycjones dannycjones approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@passaro @dannycjones