Bump to stable Rust (1.82) #1075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Burak Varli <burakvar@amazon.co.uk>
Signed-off-by: Burak Varli <burakvar@amazon.co.uk>
Signed-off-by: Vlad Volodkin <vlaad@amazon.com> (cherry picked from commit bbaead2)
unexge
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
unexge
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
unexge
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
unexge
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
unexge
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
unexge
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
unexge
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
passaro
reviewed
Oct 22, 2024
mountpoint-s3-crt-sys/build.rs
Outdated
| // detect if we're building the tests in `build.rs` at the moment, and this is the best approximation. | ||
| // See https://github.com/rust-lang/cargo/issues/1581. | ||
| let is_debug = get_env("PROFILE").unwrap_or_default() == "debug"; | ||
| if is_debug && library_name == "aws-c-common" { |
There was a problem hiding this comment.
Shall we simplify and always use +whole-archive for aws-c-common? Is the difference in final size on release significant?
There was a problem hiding this comment.
Seems like it doesn't affect the size of the mount-s3 binary:
$ # with `+whole-archive`
$ ls -lah target/release/mount-s3
-rwxr-xr-x 2 .. .. 131M Oct 23 09:53 target/release/mount-s3
$ # without `+whole-archive`
$ ls -lah target/release/mount-s3
$ -rwxr-xr-x 2 .. .. 131M Oct 23 09:58 target/release/mount-s3I updated to include +whole-archive always for aws-c-common.
Signed-off-by: Burak Varli <burakvar@amazon.co.uk>
unexge
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
unexge
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
unexge
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
unexge
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
unexge
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
unexge
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
unexge
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Our build with Rust 1.82 broken previously due to changes on Rust 1.82. This PR fixes those breakages and bumps Rust version to stable.
PanicInfotype alias #1072. Since we haverust-toolchain.tomlnow, and we don't vendmountpoint-s3as a Rust crate, we're fine to only userust-toolchain.tomland notrust-versioninCargo.toml. Although they serve to different purposes, having only one place to specify Rust version would be preferable and sufficient in our case.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).