Return the new object ETag in PutObjectResult #1057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alessandro Passaro <alexpax@amazon.co.uk>
Signed-off-by: Alessandro Passaro <alexpax@amazon.co.uk>
Signed-off-by: Alessandro Passaro <alexpax@amazon.co.uk>
passaro
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
monthonk
reviewed
Oct 15, 2024
| @@ -233,7 +226,7 @@ pub struct S3PutObjectRequest { | |||
| start_time: Instant, | |||
| total_bytes: u64, | |||
| /// Headers of the CompleteMultipartUpload response, available after the request was finished | |||
| response_headers: Arc<Mutex<Option<Headers>>>, | |||
| response_headers: Receiver<Headers>, | |||
There was a problem hiding this comment.
I would prefer response_headers_receiver and update the comment.
There was a problem hiding this comment.
Pushing back a little on this. A Receiver is a future and that's how it is used here. But happy to clarify in the comment.
There was a problem hiding this comment.
It's just not clear from the naming that we have to call .await to really get the headers, but not blocking on it.
Signed-off-by: Alessandro Passaro <alexpax@amazon.co.uk>
passaro
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
monthonk
approved these changes
Oct 15, 2024
| @@ -233,7 +226,7 @@ pub struct S3PutObjectRequest { | |||
| start_time: Instant, | |||
| total_bytes: u64, | |||
| /// Headers of the CompleteMultipartUpload response, available after the request was finished | |||
| response_headers: Arc<Mutex<Option<Headers>>>, | |||
| response_headers: Receiver<Headers>, | |||
There was a problem hiding this comment.
It's just not clear from the naming that we have to call .await to really get the headers, but not blocking on it.
rajdchak
pushed a commit
to rajdchak/mountpoint-s3-fork
that referenced
this pull request
Oct 16, 2024
* Return the ETag in PutObjectResult Signed-off-by: Alessandro Passaro <alexpax@amazon.co.uk> * Simplify handling of response headers Signed-off-by: Alessandro Passaro <alexpax@amazon.co.uk> * Move ETag to a separate module Signed-off-by: Alessandro Passaro <alexpax@amazon.co.uk> * Add comments Signed-off-by: Alessandro Passaro <alexpax@amazon.co.uk> --------- Signed-off-by: Alessandro Passaro <alexpax@amazon.co.uk>
rajdchak
pushed a commit
to rajdchak/mountpoint-s3-fork
that referenced
this pull request
Oct 16, 2024
* Return the ETag in PutObjectResult Signed-off-by: Alessandro Passaro <alexpax@amazon.co.uk> * Simplify handling of response headers Signed-off-by: Alessandro Passaro <alexpax@amazon.co.uk> * Move ETag to a separate module Signed-off-by: Alessandro Passaro <alexpax@amazon.co.uk> * Add comments Signed-off-by: Alessandro Passaro <alexpax@amazon.co.uk> --------- Signed-off-by: Alessandro Passaro <alexpax@amazon.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
On success, both
put_object(MPU) andput_object_singlereturn the ETag of the newly uploaded object.Does this change impact existing behavior?
No.
Does this change need a changelog entry in any of the crates?
Yes. Changelogs will be updated in a separate change (including changes from #1046).
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).