Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy object operation #1052

Merged
merged 6 commits into from
Oct 16, 2024
Merged

Conversation

rajdchak
Copy link
Contributor

@rajdchak rajdchak commented Oct 4, 2024

Description of change

These changes enable copy object operation. Need this operation in mountpoint to support distributed checkpointing functionality in pytorch.

Relevant issues:

Does this change impact existing behavior?

No

No breaking changes

Does this change need a changelog entry in any of the crates?


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).

@rajdchak rajdchak temporarily deployed to PR integration tests October 4, 2024 10:38 — with GitHub Actions Inactive
@rajdchak rajdchak temporarily deployed to PR integration tests October 4, 2024 10:38 — with GitHub Actions Inactive
@rajdchak rajdchak temporarily deployed to PR integration tests October 4, 2024 10:38 — with GitHub Actions Inactive
@rajdchak rajdchak temporarily deployed to PR integration tests October 4, 2024 10:38 — with GitHub Actions Inactive
@matthieu-d4r
Copy link

matthieu-d4r commented Oct 4, 2024

It looks like this PR is also bringing changes from the mountpoint folks: would it be possible to rebase instead of merging, so we're only PR-ing your changes?

Never mind, the diff looks fine — although the "Commits" list looks weird... GTG

Copy link
Contributor

@passaro passaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

It only needs to be rebased once #1061 is merged.

IsaevIlya
IsaevIlya previously approved these changes Oct 16, 2024
@passaro passaro dismissed IsaevIlya’s stale review October 16, 2024 14:43

PR cannot be merge until after rebase

Signed-off-by: rajdchak <rajdchak@amazon.co.uk>
Signed-off-by: rajdchak <rajdchak@amazon.co.uk>
Signed-off-by: rajdchak <rajdchak@amazon.co.uk>
Signed-off-by: rajdchak <rajdchak@amazon.co.uk>
Signed-off-by: rajdchak <rajdchak@amazon.co.uk>
Signed-off-by: rajdchak <rajdchak@amazon.co.uk>
@rajdchak rajdchak temporarily deployed to PR integration tests October 16, 2024 15:49 — with GitHub Actions Inactive
@rajdchak rajdchak temporarily deployed to PR integration tests October 16, 2024 15:49 — with GitHub Actions Inactive
@rajdchak rajdchak temporarily deployed to PR integration tests October 16, 2024 15:49 — with GitHub Actions Inactive
@rajdchak rajdchak temporarily deployed to PR integration tests October 16, 2024 15:49 — with GitHub Actions Inactive
@rajdchak rajdchak temporarily deployed to PR integration tests October 16, 2024 15:49 — with GitHub Actions Inactive
@rajdchak rajdchak temporarily deployed to PR integration tests October 16, 2024 15:49 — with GitHub Actions Inactive
@rajdchak rajdchak temporarily deployed to PR integration tests October 16, 2024 15:49 — with GitHub Actions Inactive
@passaro passaro added this pull request to the merge queue Oct 16, 2024
Merged via the queue into awslabs:main with commit de6c1bc Oct 16, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants