Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error handling and reporting when removing cache blocks #1043

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

passaro
Copy link
Contributor

@passaro passaro commented Oct 1, 2024

Minor improvements to how we handle removal of cache blocks:

  • distinguish between eviction and deletion of invalid blocks,
  • avoid logging failure to remove if the file was not found,
  • remove entry from usage map.

Relevant issues: #1040


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).

Signed-off-by: Alessandro Passaro <alexpax@amazon.co.uk>
Signed-off-by: Alessandro Passaro <alexpax@amazon.co.uk>
@passaro passaro temporarily deployed to PR integration tests October 1, 2024 14:21 — with GitHub Actions Inactive
@passaro passaro temporarily deployed to PR integration tests October 1, 2024 14:21 — with GitHub Actions Inactive
@passaro passaro temporarily deployed to PR integration tests October 1, 2024 14:21 — with GitHub Actions Inactive
@passaro passaro temporarily deployed to PR integration tests October 1, 2024 14:21 — with GitHub Actions Inactive
@passaro passaro temporarily deployed to PR integration tests October 1, 2024 14:21 — with GitHub Actions Inactive
@passaro passaro temporarily deployed to PR integration tests October 1, 2024 14:21 — with GitHub Actions Inactive
@passaro passaro temporarily deployed to PR integration tests October 1, 2024 14:21 — with GitHub Actions Inactive
@passaro passaro added this pull request to the merge queue Oct 1, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 1, 2024
@dannycjones dannycjones added this pull request to the merge queue Oct 1, 2024
Merged via the queue into awslabs:main with commit 4e99e79 Oct 1, 2024
23 checks passed
@passaro passaro deleted the invalid-block branch October 1, 2024 16:22
rajdchak pushed a commit to rajdchak/mountpoint-s3-fork that referenced this pull request Oct 4, 2024
…abs#1043)

* Improve error handling when removing cache blocks

Signed-off-by: Alessandro Passaro <alexpax@amazon.co.uk>

* Clean up ObjectId Debug implementation

Signed-off-by: Alessandro Passaro <alexpax@amazon.co.uk>

---------

Signed-off-by: Alessandro Passaro <alexpax@amazon.co.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants