Skip to content

Commit

Permalink
Update PR template to prompt thinking on change log entry (#968)
Browse files Browse the repository at this point in the history
* Add section on changelog updates to PR template

Signed-off-by: Daniel Carl Jones <djonesoa@amazon.com>

* Add links to changelogs

Signed-off-by: Daniel Carl Jones <djonesoa@amazon.com>

---------

Signed-off-by: Daniel Carl Jones <djonesoa@amazon.com>
  • Loading branch information
dannycjones authored Aug 2, 2024
1 parent d3a0705 commit 58edaaf
Showing 1 changed file with 13 additions and 0 deletions.
13 changes: 13 additions & 0 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,19 @@ Relevant issues: <!-- Please add issue numbers. -->

<!-- Please confirm there's no breaking change, or call our any behavior changes you think are necessary. -->

## Does this change need a changelog entry in any of the crates?

<!--
Please confirm yes or no.
If no, add justification. If unsure, ask a reviewer.
You can find the changelog for each crate here:
- https://github.com/awslabs/mountpoint-s3/blob/main/mountpoint-s3/CHANGELOG.md
- https://github.com/awslabs/mountpoint-s3/blob/main/mountpoint-s3-client/CHANGELOG.md
- https://github.com/awslabs/mountpoint-s3/blob/main/mountpoint-s3-crt/CHANGELOG.md
- https://github.com/awslabs/mountpoint-s3/blob/main/mountpoint-s3-crt-sys/CHANGELOG.md
-->

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the [Developer Certificate of Origin (DCO)](https://developercertificate.org/).

0 comments on commit 58edaaf

Please sign in to comment.