Use separate bucket for bench results, run on PRs (#985)

Signed-off-by: Vlad Volodkin <vlaad@amazon.com> Co-authored-by: Vlad Volodkin <vlaad@amazon.com>
awslabs · Aug 20, 2024 · 13ab4d9 · 13ab4d9
1 parent ba5cfc3
commit 13ab4d9
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 5 deletions.
diff --git a/.github/workflows/bench.yml b/.github/workflows/bench.yml
@@ -75,7 +75,7 @@ jobs:
       run: .github/actions/scripts/save-benchmark-results.sh
       env:
         S3_BENCH_REGION: ${{ vars.S3_BENCH_REGION }}
-        S3_BENCH_BUCKET_NAME: ${{ vars.S3_BENCH_BUCKET_NAME }}
+        S3_BENCH_BUCKET_NAME: ${{ vars.S3_BENCH_RESULTS_BUCKET_NAME }}
         S3_BENCH_RESULTS_PREFIX: ${{ inputs.s3_bench_results_prefix }}/${{ github.job }}
 
   latency-bench:
@@ -128,7 +128,7 @@ jobs:
       run: .github/actions/scripts/save-benchmark-results.sh
       env:
         S3_BENCH_REGION: ${{ vars.S3_BENCH_REGION }}
-        S3_BENCH_BUCKET_NAME: ${{ vars.S3_BENCH_BUCKET_NAME }}
+        S3_BENCH_BUCKET_NAME: ${{ vars.S3_BENCH_RESULTS_BUCKET_NAME }}
         S3_BENCH_RESULTS_PREFIX: ${{ inputs.s3_bench_results_prefix }}/${{ github.job }}
 
   cache-bench:
@@ -183,5 +183,5 @@ jobs:
       run: .github/actions/scripts/save-benchmark-results.sh
       env:
         S3_BENCH_REGION: ${{ vars.S3_BENCH_REGION }}
-        S3_BENCH_BUCKET_NAME: ${{ vars.S3_BENCH_BUCKET_NAME }}
+        S3_BENCH_BUCKET_NAME: ${{ vars.S3_BENCH_RESULTS_BUCKET_NAME }}
         S3_BENCH_RESULTS_PREFIX: ${{ inputs.s3_bench_results_prefix }}/${{ github.job }}
diff --git a/.github/workflows/bench_pr.yml b/.github/workflows/bench_pr.yml
@@ -17,10 +17,14 @@ jobs:
     with:
       environment: PR benchmarks
       ref: ${{ github.event.pull_request.head.sha }}
+      # store results with prefix defined by PR id (github.event.number)
+      s3_bench_results_prefix: ${{ github.event_name == 'pull_request_target' && format('results/{0}/s3_standard', github.event.number) || null }}
   s3express-integration:
     name: Benchmarks (s3express)
     uses: ./.github/workflows/bench_s3express.yml
     if: ${{ contains(github.event.pull_request.labels.*.name, 'performance') }}
     with:
       environment: PR benchmarks
       ref: ${{ github.event.pull_request.head.sha }}
+      # store results with prefix defined by PR id (github.event.number)
+      s3_bench_results_prefix: ${{ github.event_name == 'pull_request_target' && format('results/{0}/s3_express', github.event.number) || null }}
diff --git a/.github/workflows/bench_s3express.yml b/.github/workflows/bench_s3express.yml
@@ -76,7 +76,7 @@ jobs:
       run: .github/actions/scripts/save-benchmark-results.sh
       env:
         S3_BENCH_REGION: ${{ vars.S3_BENCH_REGION }}
-        S3_BENCH_BUCKET_NAME: ${{ vars.S3_BENCH_BUCKET_NAME }}
+        S3_BENCH_BUCKET_NAME: ${{ vars.S3_BENCH_RESULTS_BUCKET_NAME }}
         S3_BENCH_RESULTS_PREFIX: ${{ inputs.s3_bench_results_prefix }}/${{ github.job }}
 
   latency-bench:
@@ -129,5 +129,5 @@ jobs:
       run: .github/actions/scripts/save-benchmark-results.sh
       env:
         S3_BENCH_REGION: ${{ vars.S3_BENCH_REGION }}
-        S3_BENCH_BUCKET_NAME: ${{ vars.S3_BENCH_BUCKET_NAME }}
+        S3_BENCH_BUCKET_NAME: ${{ vars.S3_BENCH_RESULTS_BUCKET_NAME }}
         S3_BENCH_RESULTS_PREFIX: ${{ inputs.s3_bench_results_prefix }}/${{ github.job }}