refactor: update get_table_schema and enforce allowed_tables #806
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request introduces two main changes:
--allowed_tables
CLI argument to restrict which tables can be queried in read-only mode.get_table_schema
function by removing thedatabase_name
parameter. It now uses the database name from the connection directly.Changes
--allowed_tables
CLI argument for whitelisting tables.allowed_tables
insiderun_query
to reject unauthorized table access.database_name
argument fromget_table_schema
.get_table_schema
implementation to useDBConnectionSingleton
for the database name.Testing
get_table_schema
works correctly without thedatabase_name
argument.User Experience Improvements
--allowed_tables
CLI argumentget_table_schema
)database_name
Breaking Change
❌ No. This change is backward compatible.
RFC / Issue
Not applicable.
Checklist
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.