feat(core-mcp-server): handle SIGTERM #805
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forgive me, I see the PR comment |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #805 +/- ##
==========================================
+ Coverage 88.76% 88.77% +0.01%
==========================================
Files 560 566 +6
Lines 38754 38885 +131
Branches 5994 6013 +19
==========================================
+ Hits 34399 34520 +121
- Misses 2819 2826 +7
- Partials 1536 1539 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
scottschreckengaust
force-pushed
the
main
branch
from
842c890 to
0e1359a
Compare
scottschreckengaust
requested review from
alexa-perlov,
okhomin,
gsoundar,
gregorywright,
Kurtiscwright,
hsingh574,
Wook133,
nspring00,
aytech-in,
MichaelWalker-git,
rshevchuk-git,
PCManticore,
iddv,
arnewouters and
bidesh
as code owners
scottschreckengaust
force-pushed
the
main
branch
from
0e1359a to
e329b3e
Compare
|
@mrlikl Can we have signal.SIGHUP event? If user close terminal window(e.g. iTerm or Terminal app), the signal come with SIGHUP. |
|
@stevenshim I added the change, thank you for the suggestion |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
This PR adds signal handling for SIGTERM and SIGINT to the MCP core server, enabling graceful shutdown when the server receives termination signals.
User experience
Before: When the Q CLI exits, the MCP container server is left orphaned.
After: The server now handles termination signals properly, logging shutdown events and exiting cleanly. This ensures no lingering containers when the Q CLI exits.
Tested by building the container locally with a different tag, and adding this to q's mcp.json, when q exits, the core server container is shut down.
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change? No
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.