Skip to content

fix(aws-dataprocessing-mcp-server): fix AWS EMR and AWS Athena MCP tool with proper tagging and add annotated type to all data processing MCP tool input arg #798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jul 14, 2025

Conversation

LiyuanLD
Copy link
Member

@LiyuanLD LiyuanLD commented Jul 12, 2025

Summary

Changes

  • Fixed Tag issue for AWS Athena tool
  • Fixed Tag issue AWS EMR tool
  • Fix tool input arguments with Annotated type for all data processing tool

User experience

Before the change

  • Resource tag was incorrectly applied or not applied for AWS EMR mcp managed resource
  • Resource tag was incorrectly applied or not applied for AWS Athena mcp managed resource

After this change

  • Resource tag is properly managed for AWS EMR tool and Athena tool

Checklist

If your change doesn't seem to apply, please leave them unchecked.

  • I have reviewed the contributing guidelines
  • I have performed a self-review of this change
  • Changes have been tested
  • Changes are documented

Is this a breaking change? (Y/N)
N

RFC issue number: #614

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.

Copy link

codecov bot commented Jul 12, 2025

Codecov Report

Attention: Patch coverage is 94.95798% with 6 lines in your changes missing coverage. Please review.

Project coverage is 88.40%. Comparing base (70269e0) to head (7c76653).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...cp_server/handlers/emr/emr_ec2_instance_handler.py 77.77% 0 Missing and 4 partials ⚠️
...g_mcp_server/handlers/emr/emr_ec2_steps_handler.py 85.71% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #798      +/-   ##
==========================================
- Coverage   88.42%   88.40%   -0.03%     
==========================================
  Files         551      514      -37     
  Lines       37435    34847    -2588     
  Branches     5820     5525     -295     
==========================================
- Hits        33102    30805    -2297     
+ Misses       2763     2605     -158     
+ Partials     1570     1437     -133     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@LiyuanLD LiyuanLD marked this pull request as ready for review July 12, 2025 06:05
@naikvaib naikvaib enabled auto-merge July 12, 2025 07:11
@scottschreckengaust scottschreckengaust added the waiting-for-codeowners Code owners are needed to review label Jul 12, 2025
@naikvaib naikvaib added this pull request to the merge queue Jul 14, 2025
Merged via the queue into awslabs:main with commit d13f090 Jul 14, 2025
159 of 161 checks passed
@naikvaib naikvaib deleted the fixes branch July 14, 2025 21:42
okhomin pushed a commit to okhomin/mcp that referenced this pull request Jul 15, 2025
…ol with proper tagging and add annotated type to all data processing MCP tool input arg (awslabs#798)

* fix(aws-dataprocessing-mcp-server): fix tags issue on EMR cluster resource operations

* fix(aws-dataprocessing-mcp-server): fix tag issue and add annotated to all input for AWS Athena tool

* fix(aws-dataprocessing-mcp-server): add annotated to all input for AWS Glue tool

* fix: remove custom log definition

* fix: add more unit test for patch coverage

---------

Co-authored-by: Vaibhav Naik <101835362+naikvaib@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-for-codeowners Code owners are needed to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants