feat: Aws-msk-mcp server #592
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added tests
Songry26
requested review from
scottschreckengaust,
krokoko,
theagenticguy,
jimini55 and
alexa-perlov
alexa-perlov
added
hold-merging
|
Thank you for the contribution! Can you add a "read-only" mode that disables the ability to delete / update / mutate unless --allow-writes parameter is passed in? You can see an example of how that's managed in the Aurora DSQL MCP server: https://github.com/awslabs/mcp/blob/main/src/aurora-dsql-mcp-server/README.md |
|
Also, can you please update the main README following the latest version format and adding your MCP server to the appropriate section (under |
|
Sure, let me talk to my team first - I'll get back to this hopefully end of week. I should be able to add the read-only mode and update the main README. |
feat readonly mode
|
Changes have been made! Please take a look. |
|
Thanks! Can you please resolve the merge conflicts here? |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...-msk-mcp-server/awslabs/aws_msk_mcp_server/tools/read_config/list_configuration_revisions.py
Fixed
Show fixed
Hide fixed
scottschreckengaust
requested changes
Jul 10, 2025
alexa-perlov
approved these changes
Jul 11, 2025
CodeChanning
pushed a commit
to CodeChanning/mcp
that referenced
this pull request
Jul 14, 2025
* feat aws msk mcp server * Documentation updates * update create to be more descriptive * feat aws msk mcp server * Following instructions in readMe, have NOT written tests though * higher level updates as described in readME * Fix installation configuration in readme Added tests * fix readMe (browse by building and working) feat readonly mode * fix server name and instructions added pydantic typechecks and optional typehints * fix list_configs feat cursor deeplink install added entry to mkdocks and codeowners * fix main_test * updated owner Fixed the pyrighttests * update codeowners * Update src/aws-msk-mcp-server/README.md Co-authored-by: alexa-perlov <56009415+alexa-perlov@users.noreply.github.com> * add test coverage for clustertelemetry * Tests to increase coverage * update codeowners fix failing tests * update codeowners fix failing tests * fix tests and coverage * update tests to increase coverage * feat serverless fix test coverage * remove xml file * reran coverage tests * remove xml file again * Pydantic Field, deleted coverage.sml, fixed install button * fix cluster_arn default pydantic arg * user_agent_extra for all tools * readme reformatting * fix tests * Set default flag to allow writes * fix readme for consistency * fix: test coverage for mutate_config, read_cluster_init * fix: added aws msk docasaurus md * fix: docusaurus consistency --------- Co-authored-by: alexa-perlov <56009415+alexa-perlov@users.noreply.github.com> Co-authored-by: Alain Krok <alkrok@amazon.com> Co-authored-by: Scott Schreckengaust <scottschreckengaust@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Summary
An MSK MCP Server support create, read, and update operations offered by the python sdk
Changes
User experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change? N
RFC issue number: N/A
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.
NOTE
Please let me know before merging, e.g. if the changes seem okay and ready to merge then message me on slack before doing so. If it is not up to standard then please ignore this bit but my team would like to have some 2FA.