Skip to content

Fix double quote escaping in OKTA secrets creation script #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix double quote escaping in OKTA secrets creation script #177

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion build-script/secure-secrets-creation.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,15 @@ if [[ ! -z "$OKTA_SECRET_NAME" ]]; then
OKTA_IDP=""
fi

echo "{\"clientId\": \"$OKTA_CLIENT_ID\", \"clientSecret\": \"$OKTA_CLIENT_SECRET\", \"audience\": \"$OKTA_AUDIENCE\", \"authServerId\": \"$OKTA_AUTH_SERVER_ID\", \"idp\": \"$OKTA_IDP\", \"apiToken\": \"$OKTA_API_TOKEN\"}" > $scriptDir/tempSecretToCreate.json
# Remove surrounding quotes from environment variables if present
OKTA_CLIENT_ID_CLEAN=$(echo "$OKTA_CLIENT_ID" | sed 's/^"\(.*\)"$/\1/')
OKTA_CLIENT_SECRET_CLEAN=$(echo "$OKTA_CLIENT_SECRET" | sed 's/^"\(.*\)"$/\1/')
OKTA_AUDIENCE_CLEAN=$(echo "$OKTA_AUDIENCE" | sed 's/^"\(.*\)"$/\1/')
OKTA_AUTH_SERVER_ID_CLEAN=$(echo "$OKTA_AUTH_SERVER_ID" | sed 's/^"\(.*\)"$/\1/')
OKTA_IDP_CLEAN=$(echo "$OKTA_IDP" | sed 's/^"\(.*\)"$/\1/')
OKTA_API_TOKEN_CLEAN=$(echo "$OKTA_API_TOKEN" | sed 's/^"\(.*\)"$/\1/')

echo "{\"clientId\": \"$OKTA_CLIENT_ID_CLEAN\", \"clientSecret\": \"$OKTA_CLIENT_SECRET_CLEAN\", \"audience\": \"$OKTA_AUDIENCE_CLEAN\", \"authServerId\": \"$OKTA_AUTH_SERVER_ID_CLEAN\", \"idp\": \"$OKTA_IDP_CLEAN\", \"apiToken\": \"$OKTA_API_TOKEN_CLEAN\"}" > $scriptDir/tempSecretToCreate.json

if cmdOutput=$(aws secretsmanager describe-secret --secret-id $OKTA_SECRET_NAME 2> /dev/null); then
echo "Updating existing secret:"
Expand Down