Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update import for emr on eks blueprint #74

Merged
merged 2 commits into from
Nov 26, 2022

Conversation

lmouhib
Copy link
Contributor

@lmouhib lmouhib commented Nov 26, 2022

What does this PR do?

Change the import of the EMR on EKS AddOn and Team. The import now if from @aws-quickstart/eks-blueprints instead of having the AddOn and Team defined in the data on eks blueprint.

🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.

Motivation

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have created another PR to add a new Add-on for Terraform EKS Blueprints repo (if applicable)
  • Yes, I have updated the website/docs or website/blog section for this feature
  • Yes, I ran pre-commit run -a with this PR. Link for installing pre-commit locally

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@lmouhib lmouhib temporarily deployed to DoEKS Test November 26, 2022 19:30 Inactive
@lmouhib lmouhib temporarily deployed to DoEKS Test November 26, 2022 19:36 Inactive
Copy link
Collaborator

@vara-bonthu vara-bonthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@vara-bonthu vara-bonthu merged commit 2ad0e88 into awslabs:main Nov 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants