Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Llama2 inf2 Ray inference upgrade and bug fix #540

Merged
merged 2 commits into from
May 28, 2024
Merged

Conversation

vara-bonthu
Copy link
Collaborator

@vara-bonthu vara-bonthu commented May 27, 2024

What does this PR do?

🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.

This PR includes the following updates and fixes for the Llama2 inference setup using Ray on Inf2 instances:

Upgraded Ray Inference Setup:

  • Added LIB path to the Docker image path for Ray.
  • Updated the Ray Serve YAML configuration.
  • Fixed the environment variable setup for neuron cores in the serving script.
  • Revised the documentation with accurate deployment steps.
  • Added a Gradio Web UI app for Llama2 deployment, making it generic for use with any models by creating the model client as a config map. This approach eliminates the need to create a dedicated image for each model inference, avoiding local Docker image builds.

Motivation

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Mandatory for new blueprints. Yes, I have added a example to support my blueprint PR
  • Mandatory for new blueprints. Yes, I have updated the website/docs or website/blog section for this feature
  • Yes, I ran pre-commit run -a with this PR. Link for installing pre-commit locally

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

Copy link
Collaborator

@askulkarni2 askulkarni2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Can you please add .py and .yaml files to the ignore list for spell check in the .pre-commit.yaml?

@vara-bonthu
Copy link
Collaborator Author

LGTM! Can you please add .py and .yaml files to the ignore list for spell check in the .pre-commit.yaml?

I am thinking about a way to exclude only the code and still validate the comments under.pyand .yaml files.

@vara-bonthu vara-bonthu merged commit 61b688f into main May 28, 2024
37 checks passed
@vara-bonthu vara-bonthu deleted the llama-inf2-fix branch May 28, 2024 20:13
ovaleanu pushed a commit to ovaleanu/data-on-eks that referenced this pull request Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants