-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: NVIDIA Triton server Blueprint with vLLM #535
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LGTM! |
Signed-off-by: Vara Bonthu <vara.bonthu@gmail.com>
…iton-server-vllm
Signed-off-by: Vara Bonthu <vara.bonthu@gmail.com>
Signed-off-by: Vara Bonthu <vara.bonthu@gmail.com>
Signed-off-by: Vara Bonthu <vara.bonthu@gmail.com>
Signed-off-by: Vara Bonthu <vara.bonthu@gmail.com>
ratnopamc
approved these changes
Jun 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
ovaleanu
pushed a commit
to ovaleanu/data-on-eks
that referenced
this pull request
Aug 10, 2024
Signed-off-by: Vara Bonthu <vara.bonthu@gmail.com> Co-authored-by: Ratnopam Charabarti <ratnopamc@yahoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.
Summary
Created a new blueprint for deploying NVIDIA Triton server with vLLM.
This blueprint couldn't fit into the existing JARK or Trainium due to the amount of code and complexity.
It makes sense to have a dedicated pattern for NVIDIA Triton server, which will showcase both vLLM and TensorRT-LLM patterns.
Motivation
NVIDIA Triton with vLLM or TensorRT-LLM is a common pattern used by most users and customers for their production workloads due to the high performance it offers for inference workloads.
More
website/docs
orwebsite/blog
section for this featurepre-commit run -a
with this PR. Link for installing pre-commit locallyFor Moderators
Additional Notes