Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: NVIDIA Triton server Blueprint with vLLM #535

Merged
merged 12 commits into from
Jun 2, 2024
Merged

Conversation

vara-bonthu
Copy link
Collaborator

@vara-bonthu vara-bonthu commented May 17, 2024

What does this PR do?

🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.

Summary

Created a new blueprint for deploying NVIDIA Triton server with vLLM.
This blueprint couldn't fit into the existing JARK or Trainium due to the amount of code and complexity.
It makes sense to have a dedicated pattern for NVIDIA Triton server, which will showcase both vLLM and TensorRT-LLM patterns.

Motivation

NVIDIA Triton with vLLM or TensorRT-LLM is a common pattern used by most users and customers for their production workloads due to the high performance it offers for inference workloads.

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Mandatory for new blueprints. Yes, I have added a example to support my blueprint PR
  • Mandatory for new blueprints. Yes, I have updated the website/docs or website/blog section for this feature
  • Yes, I ran pre-commit run -a with this PR. Link for installing pre-commit locally

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@ratnopamc
Copy link
Collaborator

LGTM!

Signed-off-by: Vara Bonthu <vara.bonthu@gmail.com>
Signed-off-by: Vara Bonthu <vara.bonthu@gmail.com>
Signed-off-by: Vara Bonthu <vara.bonthu@gmail.com>
Signed-off-by: Vara Bonthu <vara.bonthu@gmail.com>
Copy link
Collaborator

@ratnopamc ratnopamc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vara-bonthu vara-bonthu merged commit bac9efb into main Jun 2, 2024
36 of 37 checks passed
@vara-bonthu vara-bonthu deleted the triton-server-vllm branch June 2, 2024 05:00
ovaleanu pushed a commit to ovaleanu/data-on-eks that referenced this pull request Aug 10, 2024
Signed-off-by: Vara Bonthu <vara.bonthu@gmail.com>
Co-authored-by: Ratnopam Charabarti <ratnopamc@yahoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants