Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump helm provider version in jupyterhub blueprint #378

Merged
merged 2 commits into from
Nov 30, 2023

Conversation

asmacdo
Copy link
Contributor

@asmacdo asmacdo commented Nov 30, 2023

What does this PR do?

Bump helm provisioner 2.12.0 -> 2.12.1

Motivation

2.12.0 of terraform helm provisioner uses helm 3.12.1 bug in it that breaks the jupyterhub blueprint
2.12.1 of terraform helm provisioner uses helm 3.12.2, in which the bug is fixed

More

  • [X ] Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • [NA ] Mandatory for new blueprints. Yes, I have added a example to support my blueprint PR
  • [ NA] Mandatory for new blueprints. Yes, I have updated the website/docs or website/blog section for this feature
  • [ kind-of*] Yes, I ran pre-commit run -a with this PR. Link for installing pre-commit locally

*I ran pre-commit, but there are errors that seem unrelated to this change.

With this change, I was able to launch jupyterhub.

NOTE The operators started up nicely, but I'm currently debugging an issue with the jhub nodes coming up. However, I doubt that is related.

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

2.12.0 included a helm bug that prevented pulling karpenter helm chart

Fixes awslabs#376
@asmacdo asmacdo changed the title 376 bump helm fix: 376 bump helm Nov 30, 2023
@askulkarni2 askulkarni2 changed the title fix: 376 bump helm chore: Bump helm provider version in jupyterhub blueprint Nov 30, 2023
Copy link
Collaborator

@askulkarni2 askulkarni2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the PR!

@askulkarni2 askulkarni2 merged commit 9cde4cf into awslabs:main Nov 30, 2023
47 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants