Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: MPI operator installation code for distributed training use case #362

Merged
merged 3 commits into from
Nov 7, 2023
Merged

Conversation

sanjeevrg89
Copy link
Contributor

@sanjeevrg89 sanjeevrg89 commented Nov 6, 2023

What does this PR do?

🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.

I have added MPI Operator installation. The goal is to use MPI Operator to run allreduce-style distributed training on Amazon EKS.

Motivation

I am working on a blog that leverages MPI operator for distributed training.

More

  • [ Yes] Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • [ No] Mandatory for new blueprints. Yes, I have added a example to support my blueprint PR
  • [ No] Mandatory for new blueprints. Yes, I have updated the website/docs or website/blog section for this feature
  • [Yes ] Yes, I ran pre-commit run -a with this PR. Link for installing pre-commit locally

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

Screenshot 2023-11-05 at 7 34 43 PM

I have tested the installation on Amazon EKS 1.27 cluster, MPI operator installation works great.

@sanjeevrg89 sanjeevrg89 changed the title MPI operator code for distributed training using Trainium instances feat: MPI operator installation code for distributed training use case Nov 6, 2023
@sanjeevrg89
Copy link
Contributor Author

Made MPI operator as an optional install for users

Copy link
Collaborator

@vara-bonthu vara-bonthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding mpi operator. One minor comment

@@ -37,3 +37,14 @@ variable "enable_amazon_prometheus" {
type = bool
default = true
}

variable "mpi_operator_version" {
description = "The version of the MPI Operator to install"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add type as string

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vara-bonthu Thank you for the feedback. I added type as string in the variable

@vara-bonthu vara-bonthu merged commit 0ecfd45 into awslabs:main Nov 7, 2023
45 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants