Reduce the number of times we run apply #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current implementation of the install scripts runs `terraform apply` 2 times per terraform module using -target. Additionally apply is run again 2 more times at the end of the script. This means that we are running terraform apply twice as much as required. This commit adds ` | tee /dev/tty` to all the apply steps so that the output can be captured and evaluated, as well as having the output print to screen.
vara-bonthu
approved these changes
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The current implementation of the install scripts runs
terraform apply2 times per terraform module using -target. Additionally apply is run again 2 more times at the end of the script.This means that we are running terraform apply twice as much as required.
This commit adds
| tee /dev/ttyto all the apply steps so that the output can be captured and evaluated, as well as having the output print to screen. ${PIPESTATUS[0]} is used to check the return code of the first command.More
website/docsorwebsite/blogsection for this featurepre-commit run -awith this PR. Link for installing pre-commit locallyFor Moderators