Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove acl using bucket policy #218

Merged
merged 1 commit into from
Jun 10, 2023
Merged

remove acl using bucket policy #218

merged 1 commit into from
Jun 10, 2023

Conversation

hitsub2
Copy link
Contributor

@hitsub2 hitsub2 commented Jun 6, 2023 •
edited
Loading

What does this PR do?

🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.

Motivation

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Mandatory for new blueprints. Yes, I have added a example to support my blueprint PR
  • Mandatory for new blueprints. Yes, I have updated the website/docs or website/blog section for this feature
  • Yes, I ran pre-commit run -a with this PR. Link for installing pre-commit locally

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

fix #200

@hitsub2 hitsub2 temporarily deployed to DoEKS Test June 6, 2023 02:22 — with GitHub Actions Inactive
@vara-bonthu
Copy link
Collaborator

Thanks for the PR 👍

@vara-bonthu vara-bonthu self-requested a review June 10, 2023 11:44
vara-bonthu
vara-bonthu approved these changes Jun 10, 2023
View reviewed changes
Copy link
Collaborator

@vara-bonthu vara-bonthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vara-bonthu vara-bonthu merged commit 4176fa7 into awslabs:main Jun 10, 2023
vara-bonthu pushed a commit that referenced this pull request Jun 11, 2023
@hitsub2 @vara-bonthu
remove acl using bucket policy (#218)
e1e2f7a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vara-bonthu vara-bonthu vara-bonthu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace s3 acl creation with bucket policy for flink on eks
2 participants
@hitsub2 @vara-bonthu