Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix region mismatch in XGBoost example #204

Merged
merged 1 commit into from
May 18, 2023

Conversation

raykrueger
Copy link
Contributor

@raykrueger raykrueger commented May 18, 2023

What does this PR do?

The Ray on EKS terraform module deploys to us-west-2 by default. The XGBoost example project declared us-east-1 as the region.

This commit moves the variable to variables.tf and defaults it to us-west-2.

Fixes #203

Motivation

It's broke yo

More

  • [X ] Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Mandatory for new blueprints. Yes, I have added a example to support my blueprint PR
  • Mandatory for new blueprints. Yes, I have updated the website/docs or website/blog section for this feature
  • Yes, I ran pre-commit run -a with this PR. Link for installing pre-commit locally

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

Tested locally with terraform plan

The Ray on EKS terraform module deploys to us-west-2 by default. The
XGBoost example project declared us-east-1 as the region.

This commit moves the variable to variables.tf and defaults it to
us-west-2.
@raykrueger raykrueger requested a review from a team as a code owner May 18, 2023 22:31
@raykrueger raykrueger temporarily deployed to DoEKS Test May 18, 2023 22:31 — with GitHub Actions Inactive
@askulkarni2 askulkarni2 merged commit d6b1751 into awslabs:main May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ray.io XGBoost example targets wrong region
2 participants