Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplifying deployment experience #143

Merged
merged 4 commits into from
Mar 20, 2023
Merged

simplifying deployment experience #143

merged 4 commits into from
Mar 20, 2023

Conversation

dalbhanj
Copy link
Contributor

What does this PR do?

🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.

Motivation

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have created another PR to add a new Add-on for Terraform EKS Blueprints repo (if applicable)
  • Yes, I have updated the website/docs or website/blog section for this feature
  • Yes, I ran pre-commit run -a with this PR. Link for installing pre-commit locally

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@dalbhanj dalbhanj requested a review from a team as a code owner March 20, 2023 14:42
@dalbhanj dalbhanj temporarily deployed to DoEKS Test March 20, 2023 14:42 — with GitHub Actions Inactive
@dalbhanj dalbhanj added the work-in-progress Do not merge yet, work in progress label Mar 20, 2023
@dalbhanj dalbhanj temporarily deployed to DoEKS Test March 20, 2023 18:13 — with GitHub Actions Inactive
Copy link
Collaborator

@vara-bonthu vara-bonthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dalbhanj It looks great with TAB feature to show multiple examples. I left few comments. I think we also need to leverage the collapsable feature to make the doc easy to read for each section without having to scroll much.

@dalbhanj dalbhanj temporarily deployed to DoEKS Test March 20, 2023 20:47 — with GitHub Actions Inactive
Copy link
Collaborator

@vara-bonthu vara-bonthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@vara-bonthu vara-bonthu merged commit 5c54fb2 into main Mar 20, 2023
@vara-bonthu vara-bonthu deleted the simplify-deployment branch March 20, 2023 21:24
@dalbhanj dalbhanj removed the work-in-progress Do not merge yet, work in progress label Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants