Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Pattern: aws-s3-sqs #27

Closed
hnishar opened this issue Jul 27, 2020 · 1 comment · Fixed by #105
Closed

New Pattern: aws-s3-sqs #27

hnishar opened this issue Jul 27, 2020 · 1 comment · Fixed by #105
Assignees
@danielmatuki
Labels
feature-request A feature should be added or improved in-progress This issue is being actively worked on

Comments

@hnishar
Copy link
Contributor

hnishar commented Jul 27, 2020 •
edited
Loading

Add your +1 👍 to help us prioritize

Overview:

This AWS Solutions Construct implements an AWS S3 Bucket that is configured to send notifications to a queue and an Amazon SQS queue

User provided props for the construct:

  • Either an existing instances of s3.Bucket or s3.BucketProps to deploy new S3 Bucket
  • Either an existing instances of sqs.Queue or sqs.QueueProps to deploy new SQS queue
  • Optional deployDeadLetterQueue to deploy the DLQ (default: true)
  • Optional deadLetterQueueProps for the DLQ

Default settings

Out of the box implementation of the Construct without any override will set the following defaults:

Amazon S3 Bucket

  • Configure Access logging for S3 Bucket
  • Enable server-side encryption for S3 Bucket using AWS managed KMS Key
  • Turn on the versioning for S3 Bucket
  • Don't allow public access for S3 Bucket
  • Retain the S3 Bucket when deleting the CloudFormation stack

Amazon SQS Queue

  • Deploy SQS dead-letter queue for the source SQS Queue
  • Enable server-side encryption for source SQS Queue using AWS Managed KMS Key
@hnishar hnishar added the feature-request A feature should be added or improved label Jul 27, 2020
@danielmatuki
Copy link
Contributor

Hi @hnishar I can help with this construct. Is there someone already working on it?

@hnishar hnishar added the in-progress This issue is being actively worked on label Nov 18, 2020
@hnishar hnishar changed the title New Pattern: aws-s3-sqs-lambda New Pattern: aws-s3-sqs Nov 23, 2020
danielmatuki added a commit to danielmatuki/aws-solutions-constructs that referenced this issue Nov 25, 2020
@danielmatuki
feat(aws-s3-sqs): New aws-s3-sqs pattern implementation (awslabs#27)
1089629
@danielmatuki danielmatuki mentioned this issue Nov 25, 2020
Merged
hnishar pushed a commit that referenced this issue Dec 16, 2020
@danielmatuki
feat(aws-s3-sqs): New aws-s3-sqs pattern implementation (#27) (#105)
80bce76 
* feat(aws-s3-sqs): New aws-s3-sqs pattern implementation (#27)

* fix(aws-s3-sqs): Added logic to suppress cfn_nag warnings for S3 bucket notifications.

* fix(aws-s3-sqs): Code review fixes

Moved addCfnNagSuppress to core. Exposed encryption key properties in s3-sqs pattern. Improved integration and unit tests.

* fix(aws-s3-sqs): Added viperlight ignore for CDK generated KMS key resource policy that allows the root account to access it.

* fix(aws-s3-sqs) Executed lint with fix option to correct the indentation to use 2 spaces.

* fix(aws-s3-sqs) Added documentation describing the need for customer managed CMK to encrypt the SQS Queue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielmatuki danielmatuki

Labels
feature-request A feature should be added or improved in-progress This issue is being actively worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(aws-s3-sqs): New aws-s3-sqs pattern implementation (#27) danielmatuki/aws-solutions-constructs
2 participants
@hnishar @danielmatuki