fix: issue #687

pyproject.toml

@@ -3,7 +3,7 @@
 
 [tool.poetry]
 name = "aws-service-catalog-puppet"
-version = "0.242.0"
+version = "0.242.1"
 description = "Making it easier to deploy ServiceCatalog products"
 classifiers = ["Development Status :: 5 - Production/Stable", "Intended Audience :: Developers", "Programming Language :: Python :: 3", "License :: OSI Approved :: Apache Software License", "Operating System :: OS Independent", "Natural Language :: English"]
 homepage = "https://service-catalog-tools-workshop.com/"

servicecatalog_puppet/commands/task_reference_helpers/hub_generator.py

@@ -3,6 +3,27 @@
 from servicecatalog_puppet import constants, serialisation_utils
 from servicecatalog_puppet.workflow import workflow_utils
 
+SECTIONS_THAT_MUST_RUN_IN_HUB = [
+    constants.PORTFOLIO_SHARE_AND_ACCEPT_ACCOUNT,
+]
+SECTIONS_THAT_MUST_RUN_IN_HUB_FOR_PUPPET_AS_A_SPOKE = [
+    constants.PORTFOLIO_PUPPET_ROLE_ASSOCIATION,
+    constants.PORTFOLIO_GET_ALL_PRODUCTS_AND_THEIR_VERSIONS,
+]
+
+
+def task_should_execute_before_spoke_execution(task, puppet_account_id):
+    if task.get("section_name") in SECTIONS_THAT_MUST_RUN_IN_HUB:
+        return True
+
+    if (
+        task.get("section_name") in SECTIONS_THAT_MUST_RUN_IN_HUB_FOR_PUPPET_AS_A_SPOKE
+        and task.get("account_id") == puppet_account_id
+    ):
+        return True
+
+    return False
+
 
 def generate(puppet_account_id, all_tasks, output_file_path):
     tasks_to_include = dict()
@@ -14,10 +35,18 @@ def generate(puppet_account_id, all_tasks, output_file_path):
         elif execution == constants.EXECUTION_MODE_SPOKE:
             # should_include = False
             # sharing should happen from the hub for launches in spoke mode
-            should_include = (
-                task.get("section_name") == constants.PORTFOLIO_SHARE_AND_ACCEPT_ACCOUNT
+            should_include = task_should_execute_before_spoke_execution(
+                task, puppet_account_id
             )
 
+            # if task.get("section_name") == constants.PORTFOLIO_SHARE_AND_ACCEPT_ACCOUNT:
+            #     should_include = True
+            # else:
+            #     if task.get("section_name") in SECTIONS_THAT_MUST_RUN_IN_HUB and task.get("account_id") == puppet_account_id:
+            #         should_include = True
+            #     else:
+            #         should_include = False
+
         elif execution == constants.EXECUTION_MODE_HUB_AND_SPOKE_SPLIT:
             # cannot assume account_id role from spoke when it is the puppet account id
             should_include = (

setup.py

@@ -73,7 +73,7 @@
 
 setup_kwargs = {
     'name': 'aws-service-catalog-puppet',
-    'version': '0.242.0',
+    'version': '0.242.1',
     'description': 'Making it easier to deploy ServiceCatalog products',
     'long_description': '# aws-service-catalog-puppet\n\n![logo](./docs/logo.png) \n\n## Badges\n\n[![codecov](https://codecov.io/gh/awslabs/aws-service-catalog-puppet/branch/master/graph/badge.svg?token=e8M7mdsmy0)](https://codecov.io/gh/awslabs/aws-service-catalog-puppet)\n\n\n## What is it?\nThis is a python3 framework that makes it easier to share multi region AWS Service Catalog portfolios and makes it \npossible to provision products into accounts declaratively using a metadata based rules engine.\n\nWith this framework you define your accounts in a YAML file.  You give each account a set of tags, a default region and \na set of enabled regions.\n\nOnce you have done this you can define portfolios should be shared with each set of accounts using the tags and you \ncan specify which regions the shares occur in.\n\nIn addition to this, you can also define products that should be provisioned into accounts using the same tag based \napproach.  The framework will assume role into the target account and provision the product on your behalf.\n\n\n## Getting started\n\nYou can read the [installation how to](https://service-catalog-tools-workshop.com/30-how-tos/10-installation/30-service-catalog-puppet.html)\nor you can read through the [every day use](https://service-catalog-tools-workshop.com/30-how-tos/50-every-day-use.html)\nguides.\n\nYou can read the [documentation](https://aws-service-catalog-puppet.readthedocs.io/en/latest/) to understand the inner \nworkings. \n\n\n## Going further\n\nThe framework is one of a pair.  The other is [aws-service-catalog-factory](https://github.com/awslabs/aws-service-catalog-factory).\nWith Service Catalog Factory you can create pipelines that deploy multi region portfolios very easily. \n\n## License\n\nThis library is licensed under the Apache 2.0 License. \n \n',
     'author': 'Eamonn Faherty',