Fix installing multiple environments in one account #283
Conversation
This commit changes the default functionality from creating the macro resources to not. This allows the onboarding service to update the base stack without redoing the same logic for knowing whether the macro resources should be created.
brtrvn
left a comment
brtrvn
left a comment
There was a problem hiding this comment.
We had discussed using the IAM role/policy as the lookup key to "know" whether the macro (and its lambda, log group, etc) had been installed in the current AWS Region. Pros/cons now that we know macros are regional?
| } | ||
|
|
||
| private boolean doesCfnMacroResourceExist() { | ||
| // this assumes that the macro resource exists in CloudFormation IFF all requisite resources also exist, |
There was a problem hiding this comment.
IFF here meaning "if and only if".
|
|
||
| private boolean doesCfnMacroResourceExist() { | ||
| // this assumes that the macro resource exists in CloudFormation IFF all requisite resources also exist, | ||
| // e.g. the macro Lambda function, execution role, and log group. this should always be true, since the |
There was a problem hiding this comment.
i.e. (in other words) not e.g. (for example)
Instead now we're just creating a "regional" IAM policy by Parameterizing the name. The assumption described in |
brtrvn
left a comment
brtrvn
left a comment
There was a problem hiding this comment.
Thanks for clarifying the comments. Looking good.
2 participants
With the addition of the multicontainer feature and the usage of the CloudFormation macro to control updates according to Application Services, the ability to install multiple environments in a single account (typically for testing purposes) was broken.
This commit fixes that bug by adding a Parameter to the base stack that will only create those CloudFormation macro resources if they do not already exist.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license