-
Notifications
You must be signed in to change notification settings - Fork 189
Add Tier to tag setting #276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PoeppingT
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @muylucir , thanks for submitting this PR! I have a few changes to suggest:
- in
tenant-onboarding-app.yamlyou have not added the Tier tag to the CodePipeline and WindowsLaunchTemplate resources. If this was intentional, can you please explain why? - the Tier Parameter needs to be passed to each of the sub-stacks:
efs,fsx, andrds. This can be done by addingTier: !Ref Tierto theParametersthose resources at the bottom oftenant-onboarding-app.yaml - the
tenant-onboarding-app.yamlCloudFormation stack is created by the SaaS Boost Onboarding Service. It's a good idea to add Tier as a parameter to that stack, but for that parameter to have any function it must be passed by the Onboarding Service. Look for thehandleOnboardingBaseProvisionedfunction inservices/onboarding-service/.../OnboardingService.javato find how those stack parameters are collected and how the stack is created in response to provisioning events.
Lastly I would recommend you test to validate your changes. This can be done by following the sample application instructions in the Getting Started Guide and validating that each resource you want to be tagged per tenant is tagged with the proper Tier.
Thanks for your contribution, and I look forward to seeing your changes soon!
|
Hi @PoeppingT A1) No other reason. I think I left it out by mistake. I will request a review after making necessary changes and testing enough. Thanks!! :) |
… CloudFormation stack through handleOnboardingBaseProvisioned
|
Hi @PoeppingT I modified the code. To pass the Tier tag as a parameter to the tenant-onboarding-app.yaml CloudFormation stack through handleOnboardingBaseProvisioned in services/onboarding-service/.../OnboardingService.java. I used the sample application to complete the necessary tests. Tier tags are normally assigned to all resources (rds, efs, ecs, etc.) created by CloudFormation stack. |
PoeppingT
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update, and for the contribution!
Cost analysis is a very important area in SaaS.
SaaS Boost supports various cost allocation tags.
However, the cost allocation tag for the tier is not supported.
Accurate cost measurement for each tier is an essential element in cost estimation.
For example, if a lower tier spends more money than a higher tier, it will adversely affect profitability. We should be able to identify this.
In the process of creating a tenant, a code was added to add the tier information to the tag and use it for cost estimation.
It's a simple fix, but I think it's necessary.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license