Allow dash in SaaS Boost environment name #274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fetching the tenant id from the pipeline tags instead of heuristics based on the pipeline name. This resolves issue awslabs#231 when the SaaS Boost environment contains a hyphen/dash character.
brtrvn
commented
Aug 12, 2022
Contributor
Author
brtrvn
left a comment
brtrvn
left a comment
There was a problem hiding this comment.
Note that tagging the CodePipeline resource has been silently failing without the IAM permissions to codepipeline:TagResource
Single quoting the table name for the Athena query did not work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the onboarding service CodePipeline listener to be more precise by fetching the tenant id from the pipeline tags instead of heuristics based on the pipeline name. Also, quote the table name (which includes the SaaS Boost environment label) in the Athena SQL queries for the Metrics service.
This resolves issue #231 when the SaaS Boost environment contains a hyphen/dash character.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license