Support FSX Ontap in AppConfig. #261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit also fixes a bug where an application configuration created with no filesystem will fail to onboard tenants. Co-authored-by: netapp-vedantsethia <Vedant.Sethia@netapp.com> Co-authored-by: netapp-dhruv-tyagi <Dhruv.Tyagi@netapp.com>
brtrvn
reviewed
Aug 4, 2022
Contributor
brtrvn
left a comment
brtrvn
left a comment
There was a problem hiding this comment.
Couple of inconsistencies between equals and hashcode and we need to make sure we're setting the WIndows mount drive letter for both FSx Windows and FSx ONTAP.
I'll push small updates to address those and then we can merge.
brtrvn
approved these changes
Aug 4, 2022
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit also fixes a bug where an application configuration created
with no filesystem will fail to onboard tenants.
Co-authored-by: netapp-vedantsethia Vedant.Sethia@netapp.com
Co-authored-by: netapp-dhruv-tyagi Dhruv.Tyagi@netapp.com
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license