RDS Bootstrap fixes #251
Merged
RDS Bootstrap fixes #251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
at the end of a line. Also update the database exist check to not use try with resources because it closes out the ResultSet before we can read it when connecting to a Postgres database.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues #241 and #250.
Update the RDS bootstrap file scanner to parse on semicolon characters only when they are at the end of a line.
Update the database existence check code to not use try with resources which was closing out the
ResultSetbefore we could read it when connecting to a Postgres database.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license