fix lints

.github/workflows/ci.yml

@@ -14,7 +14,7 @@ env:
   RUST_BACKTRACE: 1
   # Change to specific Rust release to pin
   rust_stable: stable
-  rust_nightly: nightly-2024-05-05
+  rust_nightly: nightly-2024-07-07
   rust_clippy: '1.77'
   # When updating this, also update relevant docs
   rust_min: '1.76'

aws-s3-transfer-manager/src/download/body.rs

@@ -213,7 +213,7 @@ mod tests {
             received.push(data);
         }
 
-        let expected: Vec<String> = vec![0, 1, 2].iter().map(|i| format!("chunk {i}")).collect();
+        let expected: Vec<String> = [0, 1, 2].iter().map(|i| format!("chunk {i}")).collect();
         assert_eq!(expected, received);
     }
 

aws-s3-transfer-manager/src/io/part_reader.rs

@@ -73,7 +73,7 @@ impl ReadPart for PartReader {
 
 /// Data for a single part
 pub(crate) struct PartData {
-    // 1-indexed 
+    // 1-indexed
     pub(crate) part_number: u64,
     pub(crate) data: Bytes,
 }
@@ -258,7 +258,7 @@ mod test {
     use bytes::{Buf, Bytes};
     use tempfile::NamedTempFile;
 
-    use crate::io::part_reader::{PartData, Builder, ReadPart};
+    use crate::io::part_reader::{Builder, PartData, ReadPart};
     use crate::io::InputStream;
 
     async fn collect_parts(reader: impl ReadPart) -> Vec<PartData> {
@@ -304,10 +304,7 @@ mod test {
         let expected = data.chunks(part_size).collect::<Vec<_>>();
 
         let stream = builder.build().unwrap();
-        let reader = Builder::new()
-            .part_size(part_size)
-            .stream(stream)
-            .build();
+        let reader = Builder::new().part_size(part_size).stream(stream).build();
 
         let parts = collect_parts(reader).await;
         let actual = parts.iter().map(|p| p.data.chunk()).collect::<Vec<_>>();

aws-s3-transfer-manager/src/io/path_body.rs

@@ -19,7 +19,7 @@ pub(super) struct PathBody {
     pub(super) offset: u64,
 }
 
-/// Builder for creating [`InputStream`](InputStream) from a file/path.
+/// Builder for creating [`InputStream`] from a file/path.
 ///
 /// ```no_run
 /// # {
@@ -145,7 +145,7 @@ mod test {
 
     #[test]
     fn test_explicit_content_length() {
-        let mut tmp = NamedTempFile::new().unwrap();
+        let tmp = NamedTempFile::new().unwrap();
 
         let stream = PathBodyBuilder::new()
             .path(tmp.path())

aws-s3-transfer-manager/src/lib.rs

@@ -29,6 +29,7 @@ pub mod download;
 pub mod error;
 
 /// Types and helpers for I/O
+#[allow(unused)]   // FIXME(aws-sdk-rust#1159) - remove when consumed internally by other modules
 pub mod io;
 
 /// Abstractions for downloading objects from Amazon S3

aws-s3-transfer-manager/src/upload.rs

@@ -6,7 +6,6 @@
 pub use crate::upload::request::UploadRequest;
 pub use crate::upload::response::UploadResponse;
 
-
 /// Request types for uploads to Amazon S3
 pub mod request;
 

aws-s3-transfer-manager/src/upload/request.rs

@@ -193,6 +193,7 @@ impl UploadRequest {
     }
 
     /// Split the body from the request by taking it and replacing it with the default.
+    #[allow(dead_code)]   // FIXME(aws-sdk-rust#1159) - remove when consumed internally by other modules
     pub(crate) fn take_body(&mut self) -> InputStream {
         mem::take(&mut self.body)
     }