Delete observer associated with a topic when cleanup function is called #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Multiple topics can be associated with a client. This happens when multiple subscriptions are live on a single API. In that case, clientTopics holds client => [topics]. When the cleanup function is called, we should look for a topic within an existing list of topics associated with the client to identify it. Doing this allows us to find the correct <topic, client> pair which allows us to unsubsribe the client from the topic and remove the observer tied to the topic. Leaving a "completed" observer in `topicObserver` will lead to it being reused if we cancel a subscription and then switch back to it. However since the observer has been "completed", its `next` function would never be called. In `unsubscribeFromTopic` function, we should not delete a `client` key if the list of subscribed topics is empty: the client has not been disconnected yet. The client will be disconnected when `disconnectAll` is called the next time `request` is invoked (next subscription setup).
elorzafe
reviewed
Feb 28, 2018
| } else { | ||
| this.clientTopics.delete(client); | ||
| } | ||
| this.clientTopics.set(client, topics); |
There was a problem hiding this comment.
Pending: review what happen if client expires
| } else { | ||
| this.clientTopics.delete(client); | ||
| } | ||
| this.clientTopics.set(client, topics); |
There was a problem hiding this comment.
Pending: review what happen if client expires
elorzafe
approved these changes
Feb 28, 2018
|
thanks guys, this is huge! Will this be deployed to npm soon? Thanks. |
|
Hi @menkveldj This is in npm now :) |
|
You rock! I've got a 0.1 release tomorrow. This is just in time to test and
release with real offline first! Thanks.
Sent from my cell: XXX.XXX.XXXX
* All contents contained within this email and subsequent emails are
confidential unless otherwise stated.
…On Feb 28, 2018 7:45 PM, "Manuel Iglesias" ***@***.***> wrote:
Hi @menkveldj <https://github.com/menkveldj>
This is in npm now :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#60 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AVTPmTDNY86snrKIlTgZ4jOQyrxy9B_3ks5tZ0SNgaJpZM4SUerU>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple topics can be associated with a client. This happens when
multiple subscriptions are live on a single API. In that case,
clientTopics holds client => [topics]. When the cleanup function is
called, we should look for a topic within an existing list of topics
associated with the client to identify it. Doing this allows us to find
the correct <topic, client> pair which allows us to unsubsribe the
client from the topic and remove the observer tied to the topic. Leaving
a "completed" observer in
topicObserverwill lead to it being reusedif we cancel a subscription and then switch back to it. However since
the observer has been "completed", its
nextfunction would never becalled.
In
unsubscribeFromTopicfunction, we should not delete aclientkey if thelist of subscribed topics is empty: the client has not been disconnected
yet. The client will be disconnected when
disconnectAllis called thenext time
requestis invoked (next subscription setup).