Skip to content
This repository was archived by the owner on May 21, 2025. It is now read-only.

Infer domain name from request context #67

Merged
merged 7 commits into from
Jun 24, 2020
Merged

Infer domain name from request context #67

merged 7 commits into from
Jun 24, 2020

Conversation

RaeesBhatti
Copy link
Contributor

@RaeesBhatti RaeesBhatti commented May 24, 2020

Issue #, if available:
Fixes: #46
Fixes: #13
Description of changes:
aws-lambda-go recently added support for DomainName property in RequestContext. We want to revert to that domain name rather than aws-serverless-go-api.com. This change is backwards compatible, in that, people using GO_API_HOST env variable can still use that.

I wasn't able to update dependencies properly with govendor because it keeps thowing an error when I try to do govendor get github.com/aws/aws-lambda-go@v1.17.0:

go: finding module for package github.com/aws/aws-lambda-go
can't load package: package github.com/aws/aws-lambda-go: module github.com/aws/aws-lambda-go@latest found (v1.17.0), but does not contain package github.com/aws/aws-lambda-go
Error: exit status 1

Please update dependencies manually and publish them here when reviewing this PR!

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@RaeesBhatti
Copy link
Contributor Author

RaeesBhatti commented May 30, 2020

@sapessi Is this a dead project? Should the community look for other solutions? Because I don't see any kind of review of feedback!

@sapessi
Copy link
Collaborator

sapessi commented May 30, 2020

Apologies @RaeesBhatti, I hadn't looked at this because I saw that the checks failed. Let me take a quick look

@RaeesBhatti
Copy link
Contributor Author

Thank you! The tests are failing because of dependency issues. I couldn't update to github.com/aws/aws-lambda-go@v1.17.0 because govendor kept failing on me for some reason. Please update that dependency and push to this branch and the tests should pass.

@RaeesBhatti
Copy link
Contributor Author

@sapessi I updated github.com/aws/aws-lambda-go/events. Can you please take a look again!

@sapessi
Copy link
Collaborator

sapessi commented Jun 19, 2020

Looks like the build is still failing. I suspect this is because the go.mod file is not updated to point to the latest version of the dependency, I only see a change in the sum file.

@RaeesBhatti
Copy link
Contributor Author

@sapessi I've updated the mod file and test. They're passing now. Can you take another look please!

@sapessi sapessi merged commit 54c012a into awslabs:master Jun 24, 2020
@RaeesBhatti RaeesBhatti deleted the raees/infer-domain-name branch June 24, 2020 20:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Override DefaultServerAddress from APIGatewayProxyRequest Request for overriding DefaultServerAddress
2 participants