feat: Manjaro support #99
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcomagdy
suggested changes
Jul 27, 2020
packaging/packager
Outdated
| @@ -56,7 +56,7 @@ if ! type zip > /dev/null 2>&1; then | |||
| exit 1 | |||
| fi | |||
| function package_libc_via_pacman { | |||
| if grep "Arch Linux" < /etc/os-release > /dev/null 2>&1; then | |||
| if grep -E "Arch Linux|Manjaro Linux" < /etc/os-release > /dev/null 2>&1; then | |||
There was a problem hiding this comment.
Use the full option for readability please.
--extended-regexp instead of -E
There was a problem hiding this comment.
Thanks for the review @marcomagdy. Now updated to use --extended-regexp. Please re-review when you can, thanks
- added Manjaro as an OS supporting pacman
okinskas
force-pushed
the
manjaro_support
branch
from
e22e98f to
3f677b6
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#77
I'd love to add support for Majaro.. PR?
Description of changes:
Packaging via Pacman was supported on Arch but not on Manjaro. I noticed the comment linked above and have added support in the packager script.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.