build(style): Add Checkstyle plugin for Gradle #311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markjschreiber
requested changes
Nov 16, 2023
Contributor
markjschreiber
left a comment
markjschreiber
left a comment
There was a problem hiding this comment.
Thanks for adding in a style checker! A couple of comments.
| */ | ||
| public class Main { | ||
|
|
||
| private static final Logger logger = LoggerFactory.getLogger(ListPrefix.class); |
Contributor
There was a problem hiding this comment.
Should use the Main.class logger
…eSystemInfo, TimeOutUtils
guicamest
force-pushed
the
addCheckstyle
branch
from
ec7b787 to
b211c70
Compare
cannot use hashCode
guicamest
force-pushed
the
addCheckstyle
branch
from
b211c70 to
7299fc4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #300
Description of changes:
This PR adds Checkstyle as part of the build process. The configuration is based on Checkstyle for AWS SDK V2, without some custom checks on for that specific project.
During
./gradlew build, the following tasks are executed:For the test sources only the
headercheck is applied.Given that style is now enforced during build time, many files are formatted / updated 😬 .
TODO
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.