Maintenance S3FileSystemProvider #303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ad of boolean to check if file exists
…h sourcePrefix to `copy`
…k`, remove `fs` var from `copy`
…in `pathIteratorForPublisher`, avoid intermediate collect.toList
… to S3DirectoryStream
…ted functions to `S3DirectoryStream`
…nts out of try clause
…orUri`, inline `forUri`
…d to count items in an `iterator`
…plyAsync` for a fixed value in `newDirectoryStream`
…Pagination` to `newDirectoryStreamFiltersSelf`
…n bucket does not exist`
| public void close() {} | ||
|
|
||
| /** | ||
| * Get an iterator for a {@code ListObjectsV2Publisher}. This method is protected level access only for testing |
There was a problem hiding this comment.
Can change the java doc to remove the comment about protected level access for testing.
markjschreiber
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This PR brings changes to
S3FileSystemProvider:S3DirectoryStreamFlowabletransformationshould throw NoSuchFileException when bucket not foundCoverage:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.