Skip to content

Conversation

@waahm7
Copy link
Contributor

@waahm7 waahm7 commented Apr 29, 2025

Issue #, if available:

Description of changes:

  • Data.startIndex doesn't start with 0 if the Data is a slice in a larger portion. Use endIndex instead.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@TingDaoK TingDaoK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add some regression tests for this.

@waahm7
Copy link
Contributor Author

waahm7 commented Apr 29, 2025

can we add some regression tests for this.

Sure, I will create a follow up PR.

@waahm7 waahm7 enabled auto-merge (squash) April 29, 2025 20:38
@waahm7 waahm7 merged commit 5be6550 into main Apr 29, 2025
44 of 47 checks passed
@waahm7 waahm7 deleted the fix-byte-buffer-end-bug branch April 29, 2025 20:41
@waahm7 waahm7 mentioned this pull request Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants