S3Client breaking change: DEFAULT requests must pass operation name #799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Closing this PR for now. We're going to do this in 2 stages. First, expose the operationName (see #800). Once that's released, and the Java SDK is using it, we'll roll out phase 2 which makes it required. |
Contributor
Author
|
Had to open new PR after force-pushing to this branch... #802 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
see: awslabs/aws-c-s3#439
Description of changes:
S3Clientof typeMetaRequestType.DEFAULT, the user must specify the operation name (see S3 API for canonical list of names)S3FinishedResponseContext. This can help you determine exactly which operation failed. E.g. ifMetaRequestType.PUT_OBJECTfails, you can see whether it was "PutObject", "CreateMultipartUpload", "UploadPart", or "CompleteMultipartUpload" in particular that failedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.