Skip to content

Conversation

@TingDaoK
Copy link
Contributor

@TingDaoK TingDaoK commented May 29, 2024

Issue #, if available:

  • Specifically, IotServiceTest.testIotService, when connectDirectWithConfig failed, there is no close() called for the connection, here, while the connection may already be created by failed to connect, here, and result in a resource leak. And result in the test hanging as we wait for the resources to be cleaned up

Description of changes:

  • Add a tear down override to make sure the connection is closed before exit
  • Remove badssl tests, they are flaky and I don't know why we have those similar tests to different endpoint

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants