Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add partial support for Proactive rules #499

Merged
merged 5 commits into from
May 22, 2024
Merged

Conversation

bmorrissirromb
Copy link
Collaborator

@bmorrissirromb bmorrissirromb commented May 14, 2024

Issue #, if available:
Part of #400

Description of changes:
This partially implements issue #400. Config does not support Proactive evaluation modes for Organization rules. Only single-account rules support EvaluationMode arguments.

So, this change allows single-account (non-Organization rules) rules to use proactive evaluation modes.

This will be lumped into the 0.18.0 release. I am not planning to do a 0.17.12 release.

The CLI will have two new options:

  • rdk create will support an argument for --evaluation-mode and store it in the parameters.json file
  • rdk deploy (but not deploy-organization) will this feature by reading EvaluationMode from parameters.json.

In addition to this change, there are a few minor changes lumped in here:

  • CFTs are now maintained as YAMLs, not JSONs, because YAML is just better.
  • Carlo and Nima are listed as active maintainers. JDJ is moved to a former maintainer.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@bmorrissirromb bmorrissirromb changed the title DRAFT: Add partial support for Proactive rules Add partial support for Proactive rules May 22, 2024
rdk/__init__.py Outdated Show resolved Hide resolved
rdk/template/configRuleOrganization.yaml Show resolved Hide resolved
rdk/rdk.py Outdated Show resolved Hide resolved
@depaolism depaolism merged commit 9969c2a into master May 22, 2024
1 check passed
@bmorrissirromb bmorrissirromb deleted the add-evaluation-mode branch July 29, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants