aws_future functions no longer inline #577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rust was having trouble calling these functions. aws_future didn't really NEED the functions to be inline. It wasn't really a performance thing, I just liked how inline let there be a single DECLARATION in a header. Solution is to have separate DECLARATION macro to go in a header, and an IMPLEMENTATION macro to go in a C file. Now they're normal functions.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #577 +/- ##
=======================================
Coverage 79.86% 79.86%
=======================================
Files 27 27
Lines 5805 5837 +32
=======================================
+ Hits 4636 4662 +26
- Misses 1169 1175 +6
☔ View full report in Codecov by Sentry. |
DmitriyMusatkin
approved these changes
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rust was having trouble calling
aws_future_boolfunctions, due to them only being available as inline.These functions were inline so that the we'd only need 1 declaration macro in a header. It wasn't a performance thing.
Fix is to have the macros generate normal non-inline functions, with a DECLARATION macro that goes in a header, and an IMPLEMENTATION macro that goes in a C file.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.