Move h1_stream variables, to make thread usage more explicit #504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #504 +/- ##
==========================================
- Coverage 79.43% 79.41% -0.02%
==========================================
Files 27 27
Lines 11617 11618 +1
==========================================
- Hits 9228 9227 -1
- Misses 2389 2391 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I observed this when the following tests got 202, instead of literal 200: h2_sm_acquire_stream & h2_sm_acquire_stream_multiple_connections where But applying the same fix in a few other tests that strictly check for "200"
DmitriyMusatkin
approved these changes
Mar 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some cleanup before embarking on major plumbing...
While developing HTTP/1, we stumbled into the pattern of grouping variables under
thread_dataorsynced_data, so it was more explicit how they should be accessed. But we never moved ALL the variables into the proper groups. We had a TODO about this. Now it is TODONE.Also: Fix some flaky integration tests by accepting any "2xx" status-code, not just literal "200. I observed these tests failing when they sometimes got 202, instead of 200: h2_sm_acquire_stream & h2_sm_acquire_stream_multiple_connections. But I applied the same fix to any other test I found that strictly checked for 200.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.