request idle timeout #456
Merged
request idle timeout #456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #456 +/- ##
==========================================
- Coverage 79.48% 79.40% -0.09%
==========================================
Files 27 27
Lines 11511 11546 +35
==========================================
+ Hits 9150 9168 +18
- Misses 2361 2378 +17
☔ View full report in Codecov by Sentry. |
graebm
reviewed
Oct 24, 2023
Co-authored-by: Michael Graeb <graebm@amazon.com>
graebm
reviewed
Oct 25, 2023
include/aws/http/connection.h
Outdated
Comment on lines
314
to
317
| * This can be overridden per-request by aws_http_make_request_options.idle_request_timeout. | ||
| * TODO: Only supported in HTTP/1.1 now, support it in HTTP/2 | ||
| */ | ||
| uint64_t idle_timeout_ms; |
Contributor
There was a problem hiding this comment.
maybe we just call this "response timeout" all the way down
Suggested change
| * This can be overridden per-request by aws_http_make_request_options.idle_request_timeout. | |
| * TODO: Only supported in HTTP/1.1 now, support it in HTTP/2 | |
| */ | |
| uint64_t idle_timeout_ms; | |
| * This can be overridden per-request by aws_http_make_request_options.response_timeout_ms. | |
| * TODO: Only supported in HTTP/1.1 now, support it in HTTP/2 | |
| */ | |
| uint64_t response_timeout_ms; |
Contributor
Author
There was a problem hiding this comment.
discussed, sold on response_first_byte_timeout_ms
graebm
approved these changes
Oct 26, 2023
Co-authored-by: Michael Graeb <graebm@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.