Skip to content

Conversation

@TingDaoK
Copy link
Contributor

@TingDaoK TingDaoK commented Jul 6, 2023

Issue #, if available:

Description of changes:

  • If the env var is set to empty, ignore it as it's unset.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@graebm graebm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wonder if we make this mistake in any other aws-c libraries?

@TingDaoK TingDaoK merged commit f800427 into main Jul 7, 2023
@TingDaoK TingDaoK deleted the skip-empty-proxy-env branch July 7, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants