Skip to content

Proxy config new crash #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 1, 2023
Merged

Proxy config new crash #423

merged 2 commits into from
Feb 1, 2023

Conversation

@TingDaoK
Copy link
Contributor

@TingDaoK TingDaoK commented Feb 1, 2023

Issue #, if available:

  • when error happens before allocator get assigned, it will lead to crash from aws_http_proxy_config_destroy, which will use config->allocator

Description of changes:

  • Assign allocator before any goto error

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@TingDaoK TingDaoK merged commit 0c79a1c into main Feb 1, 2023
@TingDaoK TingDaoK deleted the proxy-config-new-crash branch February 1, 2023 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DmitriyMusatkin DmitriyMusatkin DmitriyMusatkin approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TingDaoK @DmitriyMusatkin