Skip to content

Conversation

@graebm
Copy link
Contributor

@graebm graebm commented Dec 28, 2022

  • Add new error AWS_ERROR_HTTP_WEBSOCKET_PROTOCOL_ERROR
    • previously, websocket was using AWS_ERROR_HTTP_PROTOCOL_ERROR, which makes it look like an HTTP protocol error
  • Add logging for errors from websocket encoder & decoder
  • Remove some TODOs that have been taken care of

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@graebm graebm force-pushed the websocket-validation2 branch from 13ddddb to 9e78803 Compare December 28, 2022 23:33
Base automatically changed from websocket-validation2 to main December 28, 2022 23:45
@graebm graebm force-pushed the websocket-protocol-error branch from 40cad86 to cb601d7 Compare December 28, 2022 23:51
@graebm graebm marked this pull request as ready for review December 29, 2022 00:01
@graebm graebm changed the title improve websocket error logging improve websocket error reporting Dec 29, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 29, 2022

Codecov Report

Base: 79.32% // Head: 79.44% // Increases project coverage by +0.11% 🎉

Coverage data is based on head (cc09b58) compared to base (50201a7).
Patch coverage: 91.30% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #416      +/-   ##
==========================================
+ Coverage   79.32%   79.44%   +0.11%     
==========================================
  Files          27       27              
  Lines       11881    11897      +16     
==========================================
+ Hits         9425     9451      +26     
+ Misses       2456     2446      -10     
Impacted Files Coverage Δ
source/http.c 53.19% <ø> (ø)
source/websocket.c 81.99% <ø> (ø)
source/websocket_encoder.c 94.23% <80.00%> (-0.98%) ⬇️
source/websocket_decoder.c 100.00% <100.00%> (+1.58%) ⬆️
source/h2_connection.c 83.75% <0.00%> (+0.76%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@graebm graebm merged commit 4f43dba into main Dec 29, 2022
@graebm graebm deleted the websocket-protocol-error branch December 29, 2022 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants