Empty path #395
Merged
Empty path #395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waahm7
approved these changes
Oct 28, 2022
TingDaoK
reviewed
Oct 28, 2022
graebm
requested changes
Oct 28, 2022
graebm
reviewed
Oct 29, 2022
Contributor
graebm
left a comment
graebm
left a comment
There was a problem hiding this comment.
:(
sorry for being wishy washy
Contributor
|
I think what Mike meant is to revert all the change about handling empty path from However, I think it will be nice if we can handle it from our end as it’s a requirement from HTTP spec. It's basically everyone wants (No one wants to break the spec with empty path). But, I’d prefer to handle it from encoder. So, for h1, it's h1_encoder.c, and for h2, it's hpack_encoder.c |
graebm
approved these changes
Oct 31, 2022
TingDaoK
approved these changes
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#393
Description of changes:
URI spec allows for path to be empty.
However, HTTP spec says that paths that are empty should be sent as /.
Our URI parser was recently changed to treat empty path as is to be spec compliant.
This change updates http client to treat empty path as / within http request
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.