Skip to content

ConnectionManager HTTP/2 updates #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Feb 8, 2022
Merged

ConnectionManager HTTP/2 updates #360

merged 14 commits into from
Feb 8, 2022

Conversation

@TingDaoK
Copy link
Contributor

@TingDaoK TingDaoK commented Jan 25, 2022 •
edited
Loading

  • Fix a bug about goaway received. Not release a connection that's in used.
  • Don't vend connection to user until the settings done. To help user knows that the connection is really ready to use.

TODO:

  • Does it worth to put tests about http2 stuff here as we also test the stream manager stuff for http2 as the user of connection manager? I think we can just add todo here...

@graebm graebm changed the title Cm h2 update ConnectionManager HTTP/2 updates Jan 25, 2022
graebm
graebm reviewed Feb 1, 2022
View reviewed changes
@TingDaoK TingDaoK merged commit 6c98b24 into main Feb 8, 2022
@TingDaoK TingDaoK deleted the cm_h2_update branch February 8, 2022 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@graebm graebm graebm approved these changes

@bretambrose bretambrose Awaiting requested review from bretambrose

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TingDaoK @graebm