H2 message stream #344
Merged
H2 message stream #344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7b0012b.
graebm
reviewed
Oct 27, 2021
source/request_response.c
Outdated
| case AWS_HTTP_HEADER_HOST: | ||
| /* host header has been converted to :authority, do nothing here */ | ||
| break; | ||
| /* TODO: handle connection-specific header field (RFC7540 8.1.2.2) */ |
Contributor
There was a problem hiding this comment.
Itamar recently added some "connection-specific header" stuff, just heads-up
graebm
approved these changes
Nov 3, 2021
source/hpack.c
Outdated
| struct aws_http_header header; | ||
| aws_http_headers_get_index(headers, i, &header); | ||
| if (s_encode_header_field(context, &header, output)) { | ||
| if (header.compression == AWS_HTTP_HEADER_COMPRESSION_USE_CACHE && |
Contributor
There was a problem hiding this comment.
since splitting the COOKIE header is part of the HTTP/2 spec, and not the HPACK spec, this should be in h2_encoder.c
Or we can just remove it for now since the HTTP/2 spec says we MAY split cookies, but it's not required
https://httpwg.org/specs/rfc7540.html#CompressCookie
source/request_response.c
Outdated
| } | ||
|
|
||
| /* if host header found, add it as :authority */ | ||
| struct aws_byte_cursor authority_cursor; |
Contributor
There was a problem hiding this comment.
Hmmm, a closer reading of the spec makes it seem like we should NOT create authority if the user didn't put it there themselves
https://httpwg.org/specs/rfc7540.html#rfc.section.8.1.2.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.